Repository navigation
refactor(app): set field background directly in theme tokens - #3744
Conversation
The dark field background came from a Click UI token that resolved to a solid #2d2d2d. Set the field background directly in both themes instead. Dark mode now uses a translucent white overlay, so the field follows the surface beneath it. Light mode keeps its existing value.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: c274d53 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
| hovered or is the currently-selected entry. */ | ||
| --color-bg-option-active: var(--palette-neutral-712); | ||
| --color-bg-field: var(--click-field-color-background-default); | ||
| --color-bg-field: rgb(255 255 255 / 6%); |
There was a problem hiding this comment.
🟡 P2 — Translucent field token makes the floating SQL autocomplete info panel see-through in dark mode
packages/app/src/components/SQLEditor/utils.ts:175 sets .cm-completionInfo to var(--color-bg-field). CodeMirror positions that panel absolutely outside the autocomplete tooltip (left: 100% / right: 100%), so the tooltip's --color-bg-surface does not sit behind it. At 6% white, the editor text and page content under the panel now show through the help text. Give the panel an opaque surface such as var(--color-bg-surface), or keep an opaque value for floating uses of the token.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
PR Review
1 finding(s): 🔴 0 P0/P1 · 🟡 1 P2 · 🔵 0 P3 Already reported on an earlier push — no new comments. 1 unchanged from an earlier push (already inline above). Priority comes from a separate grading pass over the finished review. P3 is folded here instead of posted inline. No finding blocks merge automatically; a maintainer decides. |
Deep ReviewRefactor of dark/light field-background theme tokens: removes the Verified safe: the removed token has zero remaining references (no other consumers, Click UI does not read it back); light mode is byte-identical to the old value ( ✅ No critical issues found. 🟡 P2 -- recommended
Reviewers (3): ce-correctness-reviewer, ce-maintainability-reviewer, ce-project-standards-reviewer Testing gaps: No visual/snapshot coverage asserts No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 472 passed • 1 skipped • 1296s
Tests ran across 4 shards in parallel. |
The changelog should say why the field background is translucent: in dark mode it needs opacity so it works on different backgrounds, such as popovers.
Summary
In dark mode, the field background now has opacity so it works on different backgrounds, such as popovers. It was a solid
#2d2d2dfrom the Click UI token--click-field-color-background-default, which sat wrong on surfaces that are not the page body. This PR removes that token and sets--color-bg-fielddirectly in both themes.rgb(255 255 255 / 6%), a translucent white overlay. On the page body it stays close to the old solid color. On popovers, modals, and other surfaces it picks up the background beneath it.#fbfcff).Only the theme tokens file changes. Components already read
--color-bg-field, so nothing else needs updating.Best place to test: the Group by popover on the Search page. Its "Search fields" input sits on a popover surface, so the translucent field is visible there against the popover background.
Screenshots or video
How to reproduce
Starting point:
yarn app:dev:localconnected to the demo server, orplay.hyperdx.io, in dark mode.
On
main:background with the popover background.
On this branch:
with the popover background.
How to test on Vercel preview
Preview routes: /search
Steps:
from the popover surface.
References